Jorg Heymans wrote:
Sylvain Wallez wrote:
- core: DefaultRunnableManager
 The thread pool can be created lazily when the first Runnable is executed.

this change broke DefaultRunnableManagerTestCase.java , which does a
bunch of

runnableManager.start(  );
Thread.yield(  );
Thread.sleep( 20 );
runnableManager.execute( runnable );
Thread.yield(  );
Thread.sleep( 20 );
runnableManager.stop(  );
Thread.yield(  );
Thread.sleep( 20 );
runnableManager.dispose(  );
Thread.sleep( 20 );


I have no idea what the test actually does, or even if it can still test
the behaviour it's supposed to test.

Replacing start() by initialize() and removing calls to stop() should be just fine. Thanks for spotting this!


Sylvain

--
Sylvain Wallez                        Anyware Technologies
http://people.apache.org/~sylvain     http://www.anyware-tech.com
Apache Software Foundation Member     Research & Technology Director

Reply via email to