OK this vote is cancelled because of RequiredCharsetNames being renamed. Niall
On Sun, Jul 26, 2009 at 12:46 AM, Gary Gregory<ggreg...@seagullsoftware.com> wrote: >> -----Original Message----- >> From: Emmanuel Bourg [mailto:ebo...@apache.org] >> Sent: Saturday, July 25, 2009 12:29 PM >> To: Commons Developers List >> Subject: Re: [VOTE] Release Codec 1.4 based on RC2 >> >> Gary Gregory a écrit : >> >> > Actually, RequiredCharsetNames is like [lang]'s CharEncoding [1] >> (http://commons.apache.org/lang/api/org/apache/commons/lang/CharEncoding.h >> tm). But we've never wanted this kind of dependency from codec->lang. >> > >> > In work code, we have used [lang]'s CharEncoding and our own similar >> classes to provide what should be in the JRE IMO. There is definitely a >> need for (1) having the required-always-there charset names defined >> somewhere and (2) having some utility methods that provide unchecked >> exception version of some common operations. In this case, the common >> operations are inspired by refactorings in codec itself. >> > >> > As I have seen in other projects, we could copy [lang]'s CharEncoding to >> [codec] to make things more consistent. Well, in this case, that is just >> renaming RequiredCharsetNames to CharEncoding, which be more recognizable >> for people already familiar with [lang]. That seems like a good change. >> >> I think I would rather hardcode the charsets in the classes than >> introduce a public class. Aligning the name on the one in [lang] is a >> good idea. > > I renamed RequiredCharsetNames to CharEncoding to match [lang]. The constant > name and values are the same. > > Gary > >> >> Emmanuel Bourg --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
