On 30 November 2010 17:16, Gary Gregory <ggreg...@seagullsoftware.com> wrote: > Hm... I just noticed that VFS follows a different import convention that > other [commons] projects. > > In [lang] and [io] for example, we list java packages first and the project's > packages last. In VFS, it's the reverse. Consistency would be nice. Time to > match [lang] and [io]?
OK by me. > Time to wiki this as a guideline? Too micro? IMO, that would be fine as a guideline. Makes it a bit easier when adding new code. If there are currently no guidelines on imports, I would add: * never use wildcard imports, except perhaps for static imports of constants. > > Gary > >> -----Original Message----- >> From: Ralph Goers [mailto:ralph.go...@dslextreme.com] >> Sent: Tuesday, November 30, 2010 12:00 >> To: Commons Developers List >> Subject: Re: VFS release >> >> >> On Nov 30, 2010, at 8:40 AM, Gary Gregory wrote: >> >> > Hi All: >> > >> > I've removed unused imports. >> > >> > Any objection to organizing imports consistently? >> > >> >> Actually, those all show up in the checkstyle report. The ones you changed >> are all a consequence of the recent changes I made. I'd missed those but >> would >> have caught that the next time I ran checkstyle, although I haven't been >> paying much attention to the sandbox or examples projects. >> >> Ralph >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
