> -----Original Message----- > From: sebb [mailto:seb...@gmail.com] > Sent: Tuesday, November 30, 2010 15:57 > To: Commons Developers List > Subject: Re: VFS release > > On 30 November 2010 20:38, Gary Gregory <ggreg...@seagullsoftware.com> wrote: > > Ok, I've added some entries here: http://wiki.apache.org/commons/CodeStyle > > Thanks. > But I think the page should be flagged as DRAFT until there is general > agreement.
Done. > For example, I think import order and group order are less important > than wildcards, and deserve at most a warning. Done. Gary > > > See the latest VFS commits for this order of imports: java, javax, org, com. > Same as [io] and [lang]. > > That is the Eclipse default ordering scheme for imports. > > > Gary > > > >> -----Original Message----- > >> From: Ralph Goers [mailto:ralph.go...@dslextreme.com] > >> Sent: Tuesday, November 30, 2010 14:43 > >> To: Commons Developers List > >> Subject: Re: VFS release > >> > >> > >> On Nov 30, 2010, at 9:28 AM, sebb wrote: > >> > >> > On 30 November 2010 17:16, Gary Gregory <ggreg...@seagullsoftware.com> > >> wrote: > >> >> Hm... I just noticed that VFS follows a different import convention that > >> other [commons] projects. > >> >> > >> >> In [lang] and [io] for example, we list java packages first and the > >> project's packages last. In VFS, it's the reverse. Consistency would be > nice. > >> Time to match [lang] and [io]? > >> > > >> > OK by me. > >> > > >> >> Time to wiki this as a guideline? Too micro? > >> > > >> > IMO, that would be fine as a guideline. Makes it a bit easier when > >> > adding new code. > >> > >> I usually have IntelliJ add the imports. I have no idea what controls the > >> order it chooses. As long as like packages are grouped I really don't care > >> what the order is. > >> > >> > > >> > If there are currently no guidelines on imports, I would add: > >> > * never use wildcard imports, except perhaps for static imports of > >> constants. > >> > >> That is also reported as an error by checkstyle. > >> > >> Ralph > >> > >> > >> > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > >> For additional commands, e-mail: dev-h...@commons.apache.org > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
