Github user ajs6f commented on a diff in the pull request:
    --- Diff: 
    @@ -58,8 +60,12 @@
     public abstract class AbstractRDFParser<T extends AbstractRDFParser<T>> 
implements RDFParser, Cloneable {
    -    public static final ThreadGroup threadGroup = new ThreadGroup("Commons 
RDF parsers");
    -    private static final ExecutorService threadpool = 
Executors.newCachedThreadPool(r -> new Thread(threadGroup, r));
    +    public static final AtomicInteger threadCount = new AtomicInteger();
    +    private static Thread newThread(Runnable r) {
    --- End diff --
    Because either FindBugs or PMD (can't remember) which called out 
`ThreadGroup` as not threadsafe, which is correct as far as I know. I am in 
_no_ way wedded to this change and if we can guarantee thread-safety from 
outside the class (or simply document it as not threadsafe) I would be happy to 
pull this change out.


To unsubscribe, e-mail:
For additional commands, e-mail:

Reply via email to