ottlinger commented on code in PR #268:
URL: https://github.com/apache/creadur-rat/pull/268#discussion_r1667448780
##########
apache-rat-core/src/main/java/org/apache/rat/ReportConfiguration.java:
##########
@@ -57,129 +58,51 @@
*/
public class ReportConfiguration {
- /**
- * The styles of processing for various categories of documents.
- */
public enum Processing {
- /**
- * List file as present only
- */
+ /** List file as present only */
NOTIFICATION("List file as present"),
- /**
- * List all present licenses
- */
+ /** List all present licenses */
PRESENCE("List any licenses found"),
- /**
- * List all present licenses and unknown licenses
- */
+ /** List all present licenses and unknown licenses */
ABSENCE("List licenses found and any unknown licences");
- /**
- * the description of the processing.
- */
- private final String description;
-
-
- Processing(final String description) {
- this.description = description;
- }
-
- /**
- * Gets the description of the processing type.
- * @return
- */
- public String desc() {
- return description;
- }
+ private final String description;
+ Processing(String description) {
+ this.description = description;
+ }
+ public String desc() { return description; }
}
- /**
- * The set of defined families.
- */
+
private final ReportingSet<ILicenseFamily> families;
- /**
- * The set of defined licenses
- */
private final ReportingSet<ILicense> licenses;
- /**
- * The set of approved license family categories.
- */
private final SortedSet<String> approvedLicenseCategories;
- /**
- * The set of license categories that have are to be removed from
consideration.
- */
private final SortedSet<String> removedLicenseCategories;
- /**
- * {@code true} if we are adding license headers to the files.
- */
private boolean addingLicenses;
- /**
- * {@code true} if we are adding license headers in place (no *.new files)
- */
private boolean addingLicensesForced;
- /**
- * The copyright message to add if we are adding headers. Will be null if
we are not
- * adding copyright messages.
- */
private String copyrightMessage;
- /**
- * The IOSupplier that provides the output stream to write the report to.
- */
private IOSupplier<OutputStream> out;
- /**
- * {@code true} if the report should be styled. {@code false} if XML
should be produced.
- */
private boolean styleReport;
- /**
- * The IOSupplier that provides the stylesheet to style the XML output.
- */
private IOSupplier<InputStream> styleSheet;
- /**
- * The Reportable instance that provides the documents to process.
- */
private IReportable reportable;
- /**
- * A file filter that matches files to ignore.
- */
private IOFileFilter filesToIgnore;
- /**
- * A file filter that matches directories to ignore.
- */
private IOFileFilter directoriesToIgnore;
- /**
- * the log to write messages to.
- */
private final Log log;
- /**
- * The default filter for displaying families.
- */
private LicenseFilter listFamilies;
- /**
- * The default filter for displaying licenses.
- */
private LicenseFilter listLicenses;
- /**
- * {@code true} if this is a dry run and no processing is to take place.
- */
private boolean dryRun;
- /**
- * How to process ARCHIVE document types.
- */
private Processing archiveProcessing;
- /**
- * How to process STANDARD document types.
- */
private Processing standardProcessing;
/**
* Constructor
* @param log The Log implementation that messages will be written to.
*/
- public ReportConfiguration(final Log log) {
+ public ReportConfiguration(Log log) {
Review Comment:
is this final removal due to a differnt formatter or intended?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
