ottlinger commented on code in PR #268:
URL: https://github.com/apache/creadur-rat/pull/268#discussion_r1667448896
##########
apache-rat-core/src/main/java/org/apache/rat/ReportConfiguration.java:
##########
@@ -337,36 +256,33 @@ public IOFileFilter getDirectoriesToIgnore() {
* @param directoriesToIgnore the filter that defines the directories to
ignore.
* @see Defaults#DIRECTORIES_TO_IGNORE
*/
- public void setDirectoriesToIgnore(final IOFileFilter directoriesToIgnore)
{
+ public void setDirectoriesToIgnore(IOFileFilter directoriesToIgnore) {
this.directoriesToIgnore = directoriesToIgnore == null ?
FalseFileFilter.FALSE : directoriesToIgnore;
}
/**
* Adds a directory filter to the directories to ignore.
* @param directoryToIgnore the directory filter to add.
*/
- public void addDirectoryToIgnore(final IOFileFilter directoryToIgnore) {
+ public void addDirectoryToIgnore(IOFileFilter directoryToIgnore) {
this.directoriesToIgnore =
this.directoriesToIgnore.or(directoryToIgnore);
}
/**
- * Gets the reportable object.
* @return the thing being reported on.
*/
public IReportable getReportable() {
return reportable;
}
/**
- * Sets the reportable object.
* @param reportable the thing being reported on.
*/
- public void setReportable(final IReportable reportable) {
+ public void setReportable(IReportable reportable) {
this.reportable = reportable;
}
/**
- * Gets the IOSupplier with the style sheet.
Review Comment:
If I'm not too mistaken this will result in more javadoc warnings about
missing javadocs? Is that intended?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
