ottlinger commented on code in PR #268: URL: https://github.com/apache/creadur-rat/pull/268#discussion_r1667449071
########## apache-rat-core/src/main/java/org/apache/rat/utils/CasedString.java: ########## @@ -157,14 +157,14 @@ public String[] getSegments(final String string) { * @param stringCase The {@code StringCase} that the {@code string} argument is in. * @param string The string. */ - public CasedString(final StringCase stringCase, final String string) { + public CasedString(StringCase stringCase, String string) { this.string = string == null ? null : stringCase.assemble(stringCase.getSegments(string.trim())); this.stringCase = stringCase; } /** * Returns an array of each of the segments in this CasedString. Segments are defined as the strings between - * the separators in the CasedString. For the CAMEL case the segments are determined by the presence of a capital letter. + * the separators in the CasedString. for the CAMEL case the segments are determined by the presence of a capital letter. Review Comment: forced push side effect again ########## apache-rat-core/src/main/java/org/apache/rat/utils/CasedString.java: ########## @@ -174,10 +174,10 @@ public String[] getSegments() { /** * Converts this cased string into a {@code String} of another format. * The upper/lower case of the characters within the string are not modified. - * @param stringCase The format to convert to. Review Comment: forced push side effect -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org