Claudenw commented on code in PR #268:
URL: https://github.com/apache/creadur-rat/pull/268#discussion_r1667671564
##########
apache-rat-core/src/main/java/org/apache/rat/OptionCollection.java:
##########
@@ -581,7 +560,7 @@ static Optional<IOFileFilter> parseExclusions(final Log
log, final List<String>
if (ignoredLines > 0) {
log.info("Ignored " + ignoredLines + " lines in your exclusion
files as comments or empty lines.");
}
- return orFilter.getFileFilters().isEmpty() ? Optional.empty() :
Optional.of(orFilter);
+ return orFilter.getFileFilters().isEmpty() ? Optional.empty() :
Optional.of(new NotFileFilter(orFilter));
Review Comment:
This stuff is really messy. Testing found a bug the result was we needed to
use a Not filter because we were listing all the files to ignore. so when
constructing the filter for ignoring files we have to "not" the list of files
that was provided.
This is all going to change in the near future when we pull the Maven file
matching and exclusion code up to core.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
