rmannibucau commented on a change in pull request #721:
URL: https://github.com/apache/cxf/pull/721#discussion_r521458109
##########
File path: core/src/main/java/org/apache/cxf/common/util/ASMHelper.java
##########
@@ -342,7 +342,10 @@ public ClassWriter createClassWriter() {
TypeHelperClassLoader loader = getTypeHelperClassLoader(l);
return loader.lookupDefinedClass(className);
}
-
+ public static void addExternalClass(String className, ClassLoader l,
Class<?> cls) {
Review comment:
@dufoli
1. jandex or not does not change much things, at the end you must register
the generated class in graal so a loadClass will cover both cases, only the
generation phase will be different but CXF must get one impl for this feature
to make sense in CXF itself IMHO - and it shouldnt be that hard to do a mojo
generating proxies.
2. you don't need any custom classloader since classes are generated and
dumped (physically or not) at build time in the target/classes of your project
so you have them at runtime and just need to read them at run time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
