dufoli commented on a change in pull request #721:
URL: https://github.com/apache/cxf/pull/721#discussion_r521634019
##########
File path: core/src/main/java/org/apache/cxf/common/util/ASMHelper.java
##########
@@ -342,7 +342,10 @@ public ClassWriter createClassWriter() {
TypeHelperClassLoader loader = getTypeHelperClassLoader(l);
return loader.lookupDefinedClass(className);
}
-
+ public static void addExternalClass(String className, ClassLoader l,
Class<?> cls) {
Review comment:
TODO:
For point 1)
- I create ASMHelper as interface with public
- rename ASMHelper class to ASMHelperImpl and make it inherite of interface.
- create subclass of ASMHelperImpl for each version of ASM ? (not sure of
this part )
- create class Proxy implements ASMHelper which do nothing but just load
class from classLoader. For this part it is not clear because className is send
through a visite on ClassWriter. So it mean I need a NoOpClassWriter wich just
store className ?
- add in bus-extenstions.txt a line:
org.apache.cxf.common.util.ASMHelper$TypeHelperClassLoader:org.apache.cxf.common.util.ASMHelper$:true
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
