dufoli commented on a change in pull request #721:
URL: https://github.com/apache/cxf/pull/721#discussion_r521654591
##########
File path: core/src/main/java/org/apache/cxf/common/util/ASMHelper.java
##########
@@ -342,7 +342,10 @@ public ClassWriter createClassWriter() {
TypeHelperClassLoader loader = getTypeHelperClassLoader(l);
return loader.lookupDefinedClass(className);
}
-
+ public static void addExternalClass(String className, ClassLoader l,
Class<?> cls) {
Review comment:
indeed best is just to provide me pseudoCode of usage you expect.
Because, you are talking about SPI for ASMHelper and ClassLoader so I am bit
lost? I think we need a factory for both (because I hate static class)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
