dufoli commented on a change in pull request #721:
URL: https://github.com/apache/cxf/pull/721#discussion_r522020928



##########
File path: core/src/main/java/org/apache/cxf/common/util/ASMHelper.java
##########
@@ -342,7 +342,10 @@ public ClassWriter createClassWriter() {
         TypeHelperClassLoader loader = getTypeHelperClassLoader(l);
         return loader.lookupDefinedClass(className);
     }
-
+    public static void addExternalClass(String className, ClassLoader l, 
Class<?> cls) {

Review comment:
       @rmannibucau I have implement all for (it do not build because not 
migrate for other and I have issue of syntax validation.) 
   1) do you know how maven can fix syntax validation automatically ? be cause 
process-sources report error but do not fix them. (import sort, ...)
   2) if you are ok with this solution, I will continue with other classes.
   BTW, Huge patch 1200 LOC and it is not finished ;-)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to