rmannibucau commented on a change in pull request #721:
URL: https://github.com/apache/cxf/pull/721#discussion_r522294251
##########
File path: core/src/main/java/org/apache/cxf/common/util/ASMHelper.java
##########
@@ -342,7 +342,10 @@ public ClassWriter createClassWriter() {
TypeHelperClassLoader loader = getTypeHelperClassLoader(l);
return loader.lookupDefinedClass(className);
}
-
+ public static void addExternalClass(String className, ClassLoader l,
Class<?> cls) {
Review comment:
The classloader part can be shared, we don't have to split the code
which is the same.
The proxy generation will likely be forked until we keep the kind of facade
we have (but it has some pitfalls and is not tested).
Now if you prefer a single asm module for now it works too as a first step -
your PR is not exactly on that point, it just implies a refactoring which
enables that point ;). Once we have extensions in the bus we can refactor more
easily in a second step too. The only key point is to split bytecode generation
and loading in extensions.
Open point: will corba module be dropped (I see it uses asmhelper but if it
is deleted soon no need to handle it and then asm becomes an xml thing it seems
which can makes things easier).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
