rmannibucau commented on a change in pull request #721:
URL: https://github.com/apache/cxf/pull/721#discussion_r522027869
##########
File path: core/src/main/java/org/apache/cxf/common/util/ASMHelper.java
##########
@@ -342,7 +342,10 @@ public ClassWriter createClassWriter() {
TypeHelperClassLoader loader = getTypeHelperClassLoader(l);
return loader.lookupDefinedClass(className);
}
-
+ public static void addExternalClass(String className, ClassLoader l,
Class<?> cls) {
Review comment:
@dufoli we have slack (the-asf), can need to request an invite (don't
fully recall the details) but it should be quite straight forward to connect.
For syntax validation I'm generally doing it manually (don't think
maven-checkstyle-plugin can autoformat sources).
About the rest I'd say ASMHelperImpl can maybe be N classes and drop the
abstraction, wdyt? Also the generation is not only about namespace mapper think
we have some other proxies no?
but overall, it looks good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
