rmannibucau commented on a change in pull request #721:
URL: https://github.com/apache/cxf/pull/721#discussion_r522266029
##########
File path: core/src/main/java/org/apache/cxf/common/util/ASMHelper.java
##########
@@ -342,7 +342,10 @@ public ClassWriter createClassWriter() {
TypeHelperClassLoader loader = getTypeHelperClassLoader(l);
return loader.lookupDefinedClass(className);
}
-
+ public static void addExternalClass(String className, ClassLoader l,
Class<?> cls) {
Review comment:
@dufoli not sure i'm following, the goal is to hide ASM abstraction and
replace it by a functional API so it shouldn't be an issue. Also for something
jaxb specific you can use another SPI in the bus, sounds fine for me. They can
be implemented in the same module (ex: cxf-asm, cxf-xbean-asm9 and so on) and
instantiated at need only. wdyt?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
