reta commented on code in PR #3673:
URL: https://github.com/apache/cxf/pull/3673#discussion_r4517239862


##########
rt/transports/http/src/main/java/org/apache/cxf/transport/http/HttpClientHTTPConduit.java:
##########
@@ -111,16 +111,19 @@ public class HttpClientHTTPConduit extends 
URLConnectionHTTPConduit {
     volatile RefCount<HttpClient> clientRef;
     volatile URI sslURL;
     private final ReentrantLock initializationLock = new ReentrantLock();
+    // clients this conduit has stopped using, released on close() as they 
could still be in use
     private final Queue<RefCount<HttpClient>> deferredClientRefs = new 
ConcurrentLinkedQueue<>();

Review Comment:
   @ffang I think all modifications of the `deferredClientRefs` are happening 
under lock now, right? So we don't need `ConcurrentLinkedQueue` anymore?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to