ffang commented on code in PR #3673:
URL: https://github.com/apache/cxf/pull/3673#discussion_r4518457807
##########
rt/transports/http/src/main/java/org/apache/cxf/transport/http/HttpClientHTTPConduit.java:
##########
@@ -111,16 +111,19 @@ public class HttpClientHTTPConduit extends
URLConnectionHTTPConduit {
volatile RefCount<HttpClient> clientRef;
volatile URI sslURL;
private final ReentrantLock initializationLock = new ReentrantLock();
+ // clients this conduit has stopped using, released on close() as they
could still be in use
private final Queue<RefCount<HttpClient>> deferredClientRefs = new
ConcurrentLinkedQueue<>();
Review Comment:
Hi @reta,
Yes, you're right: every access to deferredClientRefs (in resetClient(),
close() and the client lookup) is now under initializationLock. I've changed it
to a plain ArrayList and noted in the comment that it's only accessed under the
lock.
Freeman
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
