mbeckerle commented on a change in pull request #12: Revised daffodil-io module
to require passing in a FormatInfo object.
URL: https://github.com/apache/incubator-daffodil/pull/12#discussion_r157908388
##########
File path:
daffodil-runtime1/src/main/scala/edu/illinois/ncsa/daffodil/processors/parsers/PState.scala
##########
@@ -160,14 +156,16 @@ final class PState private (
dataProcArg: DataProcessor,
var delimitedParseResult: Maybe[dfa.ParseResult],
tunable: DaffodilTunables) // Runtime tunables obtained from DataProcessor)
- extends ParseOrUnparseState(vmap, diagnosticsArg, One(dataProcArg), tunable)
- with FormatInfo {
+ extends ParseOrUnparseState(vmap, diagnosticsArg, One(dataProcArg), tunable)
{
- override def currentNode = Maybe(infoset)
-
- def codingErrorAction: CodingErrorAction = decoder.malformedInputAction()
+ def parse1(parser: Parser): Unit = {
Review comment:
Don't really need this method here. parse1 of parser is already a
centralized place to be sure that the setProcessor and unwind thereof are done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
