mbeckerle commented on a change in pull request #12: Revised daffodil-io module
to require passing in a FormatInfo object.
URL: https://github.com/apache/incubator-daffodil/pull/12#discussion_r157907307
##########
File path:
daffodil-runtime1/src/main/scala/edu/illinois/ncsa/daffodil/processors/Runtime.scala
##########
@@ -241,6 +241,7 @@ class DataProcessor(val ssrd: SchemaSetRuntimeData)
this.startElement(state, p)
p.parse1(state)
this.endElement(state, p)
+ state.setMaybeProcessor(Maybe(p)) // insures we can get context/ERD later
Review comment:
Improve comment. This point is subtle. After the end of all processing, we
still call things that ask for the ERD, and expect to find it on the
processor.context. If we don't set this, then the processor.context is Nope
(because it is set on the way into a parser, and unset back when a parser
unwinds). We want it to do this wind/unwind, but here at the ultimate top level
we want to defeat that final unwind.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
