mbeckerle commented on a change in pull request #12: Revised daffodil-io module to require passing in a FormatInfo object. URL: https://github.com/apache/incubator-daffodil/pull/12#discussion_r157909421
########## File path: daffodil-runtime1/src/main/scala/edu/illinois/ncsa/daffodil/processors/unparsers/UState.scala ########## @@ -291,6 +291,13 @@ class UStateMain private ( private var _prior: UStateForSuspension = null override def prior = _prior + override def unparse1(unparser: Unparser): Unit = { Review comment: Hmmm. Doublecheck. because there are multiple kinds of UStates, and only this one does the set/unset of the processor, maybe this wierd call-back structure is needed? If so, lots of scaladoc explaining why. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services