mbeckerle commented on a change in pull request #12: Revised daffodil-io module
to require passing in a FormatInfo object.
URL: https://github.com/apache/incubator-daffodil/pull/12#discussion_r157898907
##########
File path:
daffodil-core/src/main/scala/edu/illinois/ncsa/daffodil/dsom/SchemaSet.scala
##########
@@ -81,10 +81,13 @@ final class SchemaSet(
val validateDFDLSchemas: Boolean,
checkAllTopLevelArg: Boolean,
parent: SchemaComponent,
- override val tunable: DaffodilTunables)
+ tunableArg: DaffodilTunables)
extends SchemaComponentImpl(<schemaSet/>, parent) // a fake schema component
with SchemaSetIncludesAndImportsMixin {
+ override def tunable =
Review comment:
Is there a reason for this to be a def? Pain in the neck for debugging to
have to chase the darn pointers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
