mbeckerle commented on a change in pull request #23: This fix done for nato-stanag-5516 latest schema. URL: https://github.com/apache/incubator-daffodil/pull/23#discussion_r160751149
########## File path: daffodil-tdml/src/test/scala/edu/illinois/ncsa/daffodil/tdml/TestTDMLRunnerWarnings.scala ########## @@ -0,0 +1,35 @@ +/* + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package edu.illinois.ncsa.daffodil.tdml + +import org.junit.Test +import org.junit.AfterClass + +object TestTDMLRunnerWarnings { + val runner = Runner("/test/tdml/", "testWarnings.tdml") + + @AfterClass def shutDown { + runner.reset + } +} + +class TestTDMLRunnerWarnings { + import TestTDMLRunnerWarnings._ + + // DAFFODIL-1583 + @Test def test_warningWhenExpectingSuccess() = { runner.runOneTest("warningWhenExpectingSuccess") } Review comment: Add tests for unparserTestCase to be sure warnings also work there. Add tests that actually expect a warning, don't get it, and throw - to assure that TDML runner is in fact verifying the warnings. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
