mbeckerle commented on a change in pull request #23: This fix done for
nato-stanag-5516 latest schema.
URL: https://github.com/apache/incubator-daffodil/pull/23#discussion_r160751018
##########
File path:
daffodil-tdml/src/main/scala/edu/illinois/ncsa/daffodil/tdml/TDMLRunner.scala
##########
@@ -790,10 +800,6 @@ case class ParserTestCase(ptc: NodeSeq, parentArg:
DFDLTestSuite)
leftOverException.map { throw _ } // if we get here, throw the left over
data exception.
- // TODO: Implement Warnings
- // check for any test-specified warnings
- //verifyAllDiagnosticsFound(actual, warnings)
-
val allDiags = processor.getDiagnostics ++ actual.getDiagnostics
VerifyTestCase.verifyAllDiagnosticsFound(allDiags, warnings)
Review comment:
Need to check warnings in unparser test cases also.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
