mbeckerle commented on a change in pull request #23: This fix done for
nato-stanag-5516 latest schema.
URL: https://github.com/apache/incubator-daffodil/pull/23#discussion_r160746659
##########
File path:
daffodil-tdml/src/main/scala/edu/illinois/ncsa/daffodil/tdml/TDMLRunner.scala
##########
@@ -651,7 +651,10 @@ case class ParserTestCase(ptc: NodeSeq, parentArg:
DFDLTestSuite)
roundTrip: Boolean,
tracer: Option[Debugger]) = {
- val useSerializedProcessor = if (validationMode == ValidationMode.Full)
false else true
+ val useSerializedProcessor =
+ if (validationMode == ValidationMode.Full) false
+ else if (optWarnings.isDefined) false
Review comment:
Most warnings are compilation time; and aren't serialized. So if we have a
test that cares about warnings, we don't serialize the parser/unparser.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
