mbeckerle commented on a change in pull request #23: This fix done for
nato-stanag-5516 latest schema.
URL: https://github.com/apache/incubator-daffodil/pull/23#discussion_r160746007
##########
File path:
daffodil-runtime1/src/main/scala/edu/illinois/ncsa/daffodil/dsom/CompiledExpression1.scala
##########
@@ -377,10 +377,59 @@ class DPathElementCompileInfo(
retryMatchesERD.length match {
case 0 => noMatchError(step, possibles)
case 1 => retryMatchesERD(0)
- case _ => queryMatchError(step, matchesERD)
+ case _ => {
+ // it's ok if all the names are the same, so long as they are
+ // in separate choices, or otherwise cannot co-exist.
+ //
+ // For now we just check if they are siblings, i.e., have the
+ // same model group as parent.
+ //
+ // val ambiguousSiblings =
ambiguousModelGroupSiblings(retryMatchesERD)
+ // if (ambiguousSiblings.isEmpty)
+ // BUG
+ // This results in multiple siblings with same name, path that is
ambiguous
+ // just gets first one.
+ //
+ retryMatchesERD(0)
Review comment:
Modified per your recommendation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
