mbeckerle commented on a change in pull request #30: Performance improvements
around FormatInfo change.
URL: https://github.com/apache/incubator-daffodil/pull/30#discussion_r163697768
##########
File path:
daffodil-runtime1/src/main/scala/edu/illinois/ncsa/daffodil/processors/ProcessorBases.scala
##########
@@ -68,10 +68,24 @@ trait Processor
def runtimeDependencies: Seq[Evaluatable[AnyRef]]
var isInitialized: Boolean = false
+
+ def isPrimitive: Boolean
}
trait PrimProcessor extends Processor {
override def childProcessors: Seq[Processor] = Nil
+
+ override def isPrimitive = true
Review comment:
Scaladoc for these traits, and methods.
The whole point of forcing every parser/unparser to be classified as one of
Prim, PrimNoData, or Combinator is because things like bitOrder only need to be
considered for prim parsers. If we can recognize a prim parser, then we can
centralize checking of things like the bitOrder in the PState/UState
implementation of FormatInfo.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
