mbeckerle commented on a change in pull request #30: Performance improvements
around FormatInfo change.
URL: https://github.com/apache/incubator-daffodil/pull/30#discussion_r163698062
##########
File path:
daffodil-runtime1/src/main/scala/edu/illinois/ncsa/daffodil/processors/ProcessorStateBases.scala
##########
@@ -154,101 +158,176 @@ abstract class ParseOrUnparseState protected (
/*
* Implement the FormatInfo trait needed by the I/O layer.
*/
- final def replacingDecoder: CharsetDecoder = decoderEntry.replacingCoder
- final def reportingDecoder: CharsetDecoder = decoderEntry.reportingCoder
- final def binaryFloatRep: BinaryFloatRep =
simpleElement.erd.maybeBinaryFloatRepEv.get.evaluate(this)
+
+ /**
+ * Temporary so we can easily test performance before/after.
+ */
+ private val useNewCache = true
+
+ /*
+ * Slots that cache the value of these FormatInfo members so that
+ * they are recomputed only once per parser.
Review comment:
Fix comment .... once per parse/unparse call.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
