mbeckerle commented on a change in pull request #30: Performance improvements
around FormatInfo change.
URL: https://github.com/apache/incubator-daffodil/pull/30#discussion_r163701832
##########
File path:
daffodil-runtime1/src/main/scala/edu/illinois/ncsa/daffodil/processors/EvEncoding.scala
##########
@@ -152,25 +165,28 @@ class FillByteEv(fillByteRaw: String, charsetEv:
CharsetEv, val trd: TermRuntime
}
-class CheckEncodingEv(t: TermRuntimeData, alignmentInBits: Integer, charsetEv:
CharsetEv)
- extends Evaluatable[Ok](t)
- with InfosetCachedEvaluatable[Ok] {
-
- override lazy val runtimeDependencies = List(charsetEv)
-
- final protected def compute(state: ParseOrUnparseState): Ok = {
-
- if (!charsetEv.isConstant) {
- val dfdlCS = charsetEv.evaluate(state)
- dfdlCS.charset match {
- case nbsc: NonByteSizeCharset =>
- t.schemaDefinitionError("Only encodings with byte-sized code units
are allowed to be specified using a runtime-valued expression. " +
- "Encodings with 7 or fewer bits in their code units must be
specified as a literal encoding name in the DFDL schema. " +
- "The encoding found was '%s'.", dfdlCS.charsetName)
- case _ => // do nothing
- }
- }
-
- Ok
- }
-}
Review comment:
Removed commented code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
