mbeckerle commented on a change in pull request #30: Performance improvements around FormatInfo change. URL: https://github.com/apache/incubator-daffodil/pull/30#discussion_r163697247
########## File path: daffodil-runtime1/src/main/scala/edu/illinois/ncsa/daffodil/processors/parsers/PrimParser.scala ########## @@ -1,72 +1,81 @@ -/* Copyright (c) 2012-2014 Tresys Technology, LLC. All rights reserved. Review comment: Merged back into Parser. Allows us to seal base traits/abstract classes forcing derivation from either Prim, PrimNoData, or Combinator flavors. Prevents erroneous derivation of new traits/classes from the wrong parents. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
