mbeckerle commented on a change in pull request #30: Performance improvements
around FormatInfo change.
URL: https://github.com/apache/incubator-daffodil/pull/30#discussion_r163696118
##########
File path:
daffodil-runtime1/src/main/scala/edu/illinois/ncsa/daffodil/processors/parsers/Parser.scala
##########
@@ -110,21 +109,66 @@ trait Parser
* ProcessingError it throws a new SDE.
* */
case pe: ParseError => pstate.setFailed(pe)
+ } finally {
+ pstate.resetFormatInfoCaches()
}
if (pstate.dataProc.isDefined) pstate.dataProc.get.after(pstate, this)
pstate.setMaybeProcessor(savedParser)
}
}
-// Deprecated and to be phased out. Use the trait Parser instead.
-abstract class ParserObject(override val context: RuntimeData)
+/**
+ * A PrimParser is a parser that contains no child parsers.
+ * Combinators are NOT PrimParser
+ *
+ * This trait is preferred over PrimParserObject.
+ */
+trait PrimParser
+ extends PrimProcessor
+ with Parser
+
Review comment:
Scaladoc for this trait needed, and all the other traits and classes in this
file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
