mbeckerle commented on a change in pull request #30: Performance improvements
around FormatInfo change.
URL: https://github.com/apache/incubator-daffodil/pull/30#discussion_r163700073
##########
File path:
daffodil-io/src/main/scala/edu/illinois/ncsa/daffodil/io/NonByteSizeCharset.scala
##########
@@ -42,27 +42,64 @@ import java.nio.charset.CoderResult
import java.nio.charset.CodingErrorAction
import edu.illinois.ncsa.daffodil.util.MaybeInt
import edu.illinois.ncsa.daffodil.util.Maybe
+import java.nio.charset.Charset
+import edu.illinois.ncsa.daffodil.processors.charset.NBitsWidthCharset
/**
* By "non byte sized" we mean some number of bits less than 8.
*/
-trait NonByteSizeCharset {
- def bitWidthOfACodeUnit: Int // in units of bits
- def requiredBitOrder: BitOrder
+final class NonByteSizeCharset(val bitsCharset: NBitsWidthCharset, name:
String, decodeString: String,
Review comment:
Even that is confusing. More documentation is needed. NBitsWidth_JavaCharset
is an implementation of the JavaCharset API but it consumes nbit characters
from byteBuffers to produce charBuffer characters.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
