mbeckerle commented on a change in pull request #158: Daffodil 1080 sequences
and separators - preliminary review
URL: https://github.com/apache/incubator-daffodil/pull/158#discussion_r241939396
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/dsom/SequenceGroup.scala
##########
@@ -82,8 +81,7 @@ abstract class SequenceTermBase(
* has the sequence properties. So actual sequences, group refs to them,
* but NOT implied sequences inside choice branches.
*/
-abstract class SequenceGroupTermBase(
- xml: Node,
+abstract class SequenceGroupTermBase(xml: Node,
Review comment:
This whitespace change I can't do anything about. There's no setting for
"leave it alone unless I touch it".
If the setting leaves the first one alone and indents the 2nd and subsequent
args, then the auto formatter brings the first arg up onto the line with the
"(" if it fits. ... If I use the setting that puts it on the 2nd line, then
they ALL, throughout the file, get converted to that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
