mbeckerle commented on a change in pull request #158: Daffodil 1080 sequences and separators - preliminary review URL: https://github.com/apache/incubator-daffodil/pull/158#discussion_r241939452
########## File path: daffodil-runtime1-unparser/src/main/scala/org/apache/daffodil/processors/unparsers/SeparatedSequenceUnparsers.scala ########## @@ -126,8 +126,26 @@ class ScalarOrderedSeparatedSequenceChildUnparser( override def unparse(state: UState) = childUnparser.unparse1(state) } -class RepOrderedSeparatedSequenceChildUnparser( - childUnparser: Unparser, +class ScalarOrderedSeparatedSequenceChildUnparser(childUnparser: Unparser, + srd: SequenceRuntimeData, + trd: TermRuntimeData, + sep: Unparser, + spos: SeparatorPosition, + ssp: SeparatorSuppressionPolicy, + ssAlgorithm: SeparatorSuppressionMode) + extends ScalarOrderedSeparatedSequenceChildUnparserBase(childUnparser, srd, trd, sep, spos, ssp, ssAlgorithm) + +class PotentiallyTrailingGroupSeparatedSequenceChildUnparser(childUnparser: Unparser, Review comment: This class could be eliminated since it is identical to the preceeding. Where it is constructed could just do the new OtherClass with MixinTrait trick. Not sure how much better I like that, but I hate these classes that just serve to forward all the constructor params. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
