mbeckerle commented on a change in pull request #158: Daffodil 1080 sequences and separators - preliminary review URL: https://github.com/apache/incubator-daffodil/pull/158#discussion_r241939546
########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/SeparatedSequenceParsers.scala ########## @@ -146,8 +143,24 @@ final class ScalarOrderedSeparatedSequenceChildParser( } -final class RepOrderedExactlyNSeparatedSequenceChildParser( - childParser: Parser, +final class ScalarOrderedSeparatedSequenceChildParser(childParser: Parser, + srd: SequenceRuntimeData, + trd: TermRuntimeData, + sep: Parser, + spos: SeparatorPosition, + ssp: SeparatorSuppressionPolicy) + extends ScalarOrderedSeparatedSequenceChildParserBase(childParser, srd, trd, sep, spos, ssp) + +final class PotentiallyTrailingGroupSeparatedSequenceChildParser(childParser: Parser, Review comment: As above. This class could be eliminated. See corresponding comments about Unparser side. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
