mbeckerle commented on a change in pull request #158: Daffodil 1080 sequences
and separators - preliminary review
URL: https://github.com/apache/incubator-daffodil/pull/158#discussion_r241939436
##########
File path:
daffodil-runtime1-unparser/src/main/scala/org/apache/daffodil/processors/unparsers/SeparatedSequenceUnparsers.scala
##########
@@ -112,8 +113,7 @@ trait Separated { self: SequenceChildUnparser =>
val childProcessors = Vector(childUnparser, sep)
}
-class ScalarOrderedSeparatedSequenceChildUnparser(
- childUnparser: Unparser,
+sealed abstract class
ScalarOrderedSeparatedSequenceChildUnparserBase(childUnparser: Unparser,
Review comment:
If this class is unsealed.... then... see next comment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
