stevedlawrence commented on a change in pull request #205: Update Line counter 
for new modules and schemas.
URL: https://github.com/apache/incubator-daffodil/pull/205#discussion_r288186414
 
 

 ##########
 File path: project/plugins.sbt
 ##########
 @@ -32,3 +32,5 @@ dependencyOverrides ++= Seq(
   "org.codehaus.plexus" % "plexus-utils" % "3.0.17",
   "com.google.guava" % "guava" % "20.0"
 )
+
+// addSbtPlugin("com.orrsella" % "sbt-stats" % "1.0.9-SNAPSHOT")
 
 Review comment:
   Ah, that's a bummer. So it only provides the files in 
``src/main/{java/scala}``? Maybe a more backwards compatible change and 
something more sbt-y would be to do something like:
   
   1. Add a new ``analyzeResources()`` method, which would be called in 
additional to analyze, and would pass in resources for when people need to 
analyze stuff in ``src/main/resources/``. A default method could be provided to 
in the base class to return nothing so existing stuff doesn't break.
   2. Make it so stats can run in the "test" configuration. Then you could run 
``sbt test:stats`` to get stats about things in ``src/test/{java,scala}`` and 
``src/test/resources``.'
   
   These changes would make it so output doesn't change for anyone already 
using the plugin, but could be used for people like us that need status about 
resources and tests.
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to