stevedlawrence commented on a change in pull request #205: Update Line counter
for new modules and schemas.
URL: https://github.com/apache/incubator-daffodil/pull/205#discussion_r288230015
##########
File path: project/plugins.sbt
##########
@@ -32,3 +32,5 @@ dependencyOverrides ++= Seq(
"org.codehaus.plexus" % "plexus-utils" % "3.0.17",
"com.google.guava" % "guava" % "20.0"
)
+
+// addSbtPlugin("com.orrsella" % "sbt-stats" % "1.0.9-SNAPSHOT")
Review comment:
Ugh, I guess it doesn't matter. Seems fine to me.
Only thing I'd say is that the commented out ``addSbtPlugin`` line might be
confusing since the "real" sbt-stats plugin doesn't have a version
1.0.9-SNAPSHOT. Thoughts on removing that line and we can provide documentation
somewhere (maybe on the wiki?) on how to install and enable the custom line
counter tailored towards counting lines in Daffodil and DFDL projects?
Something like:
1. CLone our fork from XYZ
2. Install it with ``sbt localInstall``
3. Modify ``~/.sbt/1.0/plugins/plugins.sbt`` to have the ``addSbtPlugin``
line
4. Run ``sbt stats`` on any project (Daffodil or DFDL schema project) to get
the stats for that project.
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services