stevedlawrence commented on a change in pull request #205: Update Line counter
for new modules and schemas.
URL: https://github.com/apache/incubator-daffodil/pull/205#discussion_r273442399
##########
File path: daffodil-lib/src/test/scala/LineCounter.scala
##########
@@ -30,33 +30,48 @@ object LineCounter extends App {
/**
* What file extensions to count.
*/
- val fileSuffixesToInclude = List(".scala", ".java", ".tdml", ".xsd") // not
.xml as some of those are data files that are giant.
+ val fileSuffixesToInclude = List(".scala", ".java", ".tdml", ".xsd",
".tdml.xml", ".xsl", ".sch", ".sbt") // not just .xml as some of those are data
files that are giant.
+
+ /**
+ * What to exclude (subversion artifacts, anything generated, version
control stuff, caches, settings, etc.)
+ */
+ val directoriesToExclude = List(".svn", ".git", ".settings", "lib_managed",
"src_managed", "resource_managed", "bin", ".cache", "target", "lib", ".idea")
/**
* Where is this freakin' sandbox anyway....edit to point to yours.
*/
val root = "/home/mbeckerle/dataiti/git/"
+ val daffodilDirsCountedSeparately = List("daffodil-test",
+ "daffodil-test-ibm1",
+ "tutorials",
+ "test-stdLayout")
/**
- * What modules within the sandbox to count
+ * What modules within the daffodil subtree sandbox to count
*/
- val srcModulesToInclude = List("daffodil-core", "daffodil-runtime1",
"daffodil-runtime1-unparser", "daffodil-lib", "daffodil-propgen",
"daffodil-tdml", "daffodil-io", "daffodil-cli", "daffodil-japi",
"daffodil-sapi")
- val unitTestModulesToInclude = srcModulesToInclude
+ val srcModulesToInclude = {
+ val daf = new File(root + "daffodil")
Review comment:
This assumes the daffodil source directory is called "daffodil". Which isn't
always true. Some other common names are going to be "incubator-daffodil" or
"daffodil.git", "incubator-daffodil.git", etc. This shouldn't be hardcodede in
here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
