stevedlawrence commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285185418
########## File path: daffodil-lib/src/main/scala/org/apache/daffodil/api/DaffodilTunables.scala ########## @@ -93,6 +93,12 @@ case class DaffodilTunables( // val requireFloatingProperty: Boolean = false, // + // If true, require that the emptyElementPolicy property is specified. If + // false, warn about missing property + // + val requireEmptyElementPolicyProperty: Boolean = false, + val emptyElementPolicy: Option[EmptyElementPolicy] = None, Review comment: What if we change this to ``defaultEmptyElementPolcy`` or something to make it more clear that this is only used it the schema doesn't set the property? We could also not make this an Option and make the default value EmptyAllowed, and the user can overwrite the default if they want. Then if we ever want to change the default, we just need to update the tunable. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
