bsloane1650 commented on a change in pull request #259: Incremental progress on
schema compilation space/speed issue.
URL: https://github.com/apache/incubator-daffodil/pull/259#discussion_r301313247
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/dsom/CompiledExpression.scala
##########
@@ -145,13 +144,13 @@ class ExpressionCompiler[T <: AnyRef] extends
ExpressionCompilerBase[T] {
val isEvaluatedAbove = false
val exprOrLiteral = property.value
val namespacesForNamespaceResolution = property.location.namespaces
- val compileInfoWherePropertyWasLocated = propertyCompileInfo(property)
+ val compileInfoWhereExpressionWasLocated = propertyCompileInfo(property)
val compiled1 = compileExpression(
qn,
staticNodeInfoKind,
exprOrLiteral,
namespacesForNamespaceResolution,
- compileInfo,
+ compileInfoWhereExpressionWasLocated, // Note: Fixed. This was just
compileInfo, which isn't right.
Review comment:
Is there a reason to keep this comment in the source code?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
