bsloane1650 commented on a change in pull request #259: Incremental progress on
schema compilation space/speed issue.
URL: https://github.com/apache/incubator-daffodil/pull/259#discussion_r302116744
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/dpath/Expression.scala
##########
@@ -943,155 +950,148 @@ sealed abstract class StepExpression(val step: String,
val pred: Option[Predicat
NodeInfo.ArrayIndex
}
+}
+
+sealed abstract class DownStepExpression(s: String, predArg:
Option[PredicateExpression])
+ extends StepExpression(s, predArg) {
+
override lazy val inherentType: NodeInfo.Kind = {
if (!isLastStep) NodeInfo.Complex
else {
- if (stepElement.optPrimType.isDefined) {
+ if (stepElements.head.optPrimType.isDefined) {
Review comment:
It is still a regression in that we would be introducing a bug where one did
not previously exist. The only question is if anyone will notice. You are
probably correct that no one would notice; but if someone did notice, it would
clearly be a bug in Daffodil (or, at least non standards compliant behavior).
As Daffodil continues to grow in popularity and capabilities, it seems to me to
be only a matter of time until someone tries to do this for some reason.
At a minimum, can we make this a Not Yet Implemented SDE? That seems less
confusing, both to a hypothetical user that stumbles onto this, and a developer
who notices that we are emitting an SDE for legal behaviour.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
