bsloane1650 commented on a change in pull request #259: Incremental progress on schema compilation space/speed issue. URL: https://github.com/apache/incubator-daffodil/pull/259#discussion_r303222520
########## File path: daffodil-test/src/test/resources/org/apache/daffodil/section23/dfdl_expressions/expressions3.tdml ########## @@ -0,0 +1,400 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> + +<tdml:testSuite + suiteName="expressions3" + xmlns:tdml="http://www.ibm.com/xmlns/dfdl/testData"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xmlns:xs="http://www.w3.org/2001/XMLSchema"; + xmlns:dfdl="http://www.ogf.org/dfdl/dfdl-1.0/"; + xmlns:dfdlx="http://www.ogf.org/dfdl/dfdl-1.0/extensions"; + xmlns:ex="http://example.com"; + xmlns:fn="http://www.w3.org/2005/xpath-functions"; + defaultRoundTrip="true"> + + <tdml:defineSchema name="s1" elementFormDefault="unqualified"> + <xs:include schemaLocation="org/apache/daffodil/xsd/DFDLGeneralFormat.dfdl.xsd" /> + <dfdl:format ref="ex:GeneralFormat" lengthKind="delimited"/> + + <xs:group name="g"> + <!-- + The path expression below is going to have different type + elements for the different instances of this group in the + final schema. + + Ultimately they all are converted to string. + --> + <xs:sequence> + <xs:choice dfdl:choiceDispatchKey="{ ../foo/bar }"> Review comment: Should this have an explicit cast to xs:string ? I believe the existing behavior is that an automatic cast at the top level is generated, but will emit a depreciation warning. Unless we are explicitly checking that the depreciation warning is being generated, we should probably future-proof this and insert the cast. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
