stevedlawrence commented on a change in pull request #262: Unordered sequences
URL: https://github.com/apache/incubator-daffodil/pull/262#discussion_r323990892
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/grammar/AlignedMixin.scala
##########
@@ -47,12 +47,14 @@ case class LengthMultipleOf(nBits: Long) extends
LengthApprox
trait AlignedMixin extends GrammarMixin { self: Term =>
+ val isInUnorderedSequence: Boolean = nearestEnclosingSequence.isDefined &&
!nearestEnclosingSequence.get.isOrdered
+
Review comment:
Maybe this makes more sense to be in the Term trait? This variable isn't
really specific to AlignedStuff, except for that's where it's currently used. I
imagine this could be useful in othe parts of the code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
