stevedlawrence commented on a change in pull request #262: Unordered sequences
URL: https://github.com/apache/incubator-daffodil/pull/262#discussion_r323998939
##########
File path:
daffodil-runtime1/src/main/scala/org/apache/daffodil/infoset/InfosetImpl.scala
##########
@@ -1415,6 +1423,50 @@ sealed class DIComplex(override val erd:
ElementRuntimeData, val tunable: Daffod
}
}
+ final def sortChildNodesByPosition(): Unit = {
+ // TODO: Once we upgrade to Scala 2.13 we can call the inplace sort
method: DAFFODIL-2152
+ // childNodes = childNodes.sortInPlace(_.erd.position)
+ childNodes = childNodes.sortBy(_.erd.position)
+ }
+
+ /*
+ * When parsing unordered sequences it is possible to have non-contiguous
arrays.
+ * When parsed, these arrays show up as separate DIArrays in the infoset. We
need
+ * to combine these separate arrays.
+ * */
Review comment:
Needs documentation about what this is returning. Looks like it returns a
list of ERDs that are not valid? Presuming the caller will then create
ValidationErrors? Is it possible/does it make sense to just have this function
create ValidationErrors directly?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
