2 It is necessary to split large pr into small pr. I agree with the second option.
Jave-Chen <[email protected]> 于2020年7月9日周四 上午7:30写道： > On one hand, since everyone is free to create issues, different users > may create > issues for the same reason. > > > > On the other hand, spliting a large PR into multiple small PRs > requires developers > to read all prs, would it be inappropriate ？ > > > > > ------------------ 原始邮件 ------------------ > 发件人: "CalvinKirs"<[email protected]>; > 发送时间: 2020年7月9日(星期四) 凌晨2:02 > 收件人: "[email protected]"< > [email protected]>; > > 主题: Re:[Vote] Pull Request Title Specification > > > > Hi, I think this is a question worthy of recognition. I think our > big pr should be separated, corresponding to an isuess, if it cannot be > split, can it be aggregated into an isuess，how do you think？If I am wrong, > please correct me > > > Best regards！ > CalvinKirs > > > On 07/8/2020 22:22，Jave-Chen<[email protected]> wrote： > A PR may be associated with multiple issues, so writing Issue No. in PR > titile may&nbsp; > be miscellaneous. > > > > ------------------&nbsp;原始邮件&nbsp;------------------ > 发件人:&nbsp;"Yichao Yang"<[email protected]&gt;; > 发送时间:&nbsp;2020年7月8日(星期三) 晚上9:29 > 收件人:&nbsp;"dev"<[email protected]&gt;; > > 主题:&nbsp;[Vote] Pull Request Title Specification > > > > Hi all, > > > After referring to the practices of other open source communities on the > title of pull request, we propose two pre selection schemes for dolphin > scheduler. > > > First： > > Specification: > > [`Open Source Project Name`-`Issue No`][`Module Name`] `Pull Request > Description` > > example： > > [DS-3333][server] Fix the xxx exception > > [DS-3333][server] Implement xxx > > ... > > > > > Second： > > Specification: > > [`Pull Request Type`-`Issue No`][`Module Name`] `Pull Request Description` > > example： > > [Fix-3333][server] Fix the xxx exception > > [Feature-3333][server] Implement xxx > > ... > > The Pull Request type is shown in the screenshot in [1]. > > > > > If you agree with the first one as the title of the pull request, reply 1, > and the second one reply 2. If there is no other suggestions after 7 days, > we will choose the first one. > > > > > -------------------------------------------------------- > > > > > 目前参考了其他开源社区的对于 Pull Request 标题的实践之后，针对 DolphinScheduler 我们提出了两种预选的方案： > > > 第一种： > > Specification: > > [`Open Source Project Name`-`Issue No`][`Module Name`] `Pull Request > Description` > > example： > > [DS-3333][server] Fix the xxx exception > > [DS-3333][server] Implement xxx > > ... > > > > > 第二种： > > Specification: > > [`Pull Request Type`-`Issue No`][`Module Name`] `Pull Request Description` > > example： > > [Fix-3333][server] Fix the xxx exception > > [Feature-3333][server] Implement xxx > > ... > > Pull Request Type 类型在 [1] 中截图给出。 > > > > > 如果想选第一种作为Pull request 标题，则回复1，第二种则回复2。没有其他意见或者建议的话，7天之后默认以第一种作为 Pull > Request 规范。 > > > > > [1] Pull Request Type: > https://github.com/apache/incubator-dolphinscheduler-website/pull/147 > > > > > Best, > > Yichao Yang -- DolphinScheduler(Incubator) PPMC Jun Gao 高俊 [email protected]
