Hello, I personally think that repeated issues need to be closed, he will cause us to have multiple copies, and also need to spend extra energy to maintain multiple issues, in addition, if the big pr is disassembled, (provided that each sub-item Do not affect each other), if it can not be disassembled, it is recommended to summarize an issue. We always hope to solve the problem with the smallest granularity. This will be very easy for developers and reviewers
| | Kirs | | [email protected] | Signature is customized by Netease Mail Master On 07/09/2020 07:29, Jave-Chen wrote: On one hand, since everyone is free to create issues, different users may create issues for the same reason. On the other hand, spliting a large PR into multiple small PRs requires developers to read all prs, would it be inappropriate ?? ------------------ ???????? ------------------ ??????: "CalvinKirs"<[email protected]>; ????????: 2020??7??9??(??????) ????2:02 ??????: "[email protected]"<[email protected]>; ????: Re:[Vote] Pull Request Title Specification Hi, I think this is a question worthy of recognition. I think our big pr should be separated, corresponding to an isuess, if it cannot be split, can it be aggregated into an isuess??how do you think??If I am wrong, please correct me Best regards?? CalvinKirs On 07/8/2020 22:22??Jave-Chen<[email protected]> wrote?? A PR may be associated with multiple issues, so writing Issue No. in PR titile may&nbsp; be miscellaneous. ------------------&nbsp;????????&nbsp;------------------ ??????:&nbsp;"Yichao Yang"<[email protected]&gt;; ????????:&nbsp;2020??7??8??(??????) ????9:29 ??????:&nbsp;"dev"<[email protected]&gt;; ????:&nbsp;[Vote] Pull Request Title Specification Hi all, After referring to the practices of other open source communities on the title of pull request, we propose two pre selection schemes for dolphin scheduler. First?? Specification: [`Open Source Project Name`-`Issue No`][`Module Name`] `Pull Request Description` example?? [DS-3333][server] Fix the xxx exception [DS-3333][server] Implement xxx ... Second?? Specification: [`Pull Request Type`-`Issue No`][`Module Name`] `Pull Request Description` example?? [Fix-3333][server] Fix the xxx exception [Feature-3333][server] Implement xxx ... The Pull Request type is shown in the screenshot in [1]. If you agree with the first one as the title of the pull request, reply 1, and the second one reply 2. If there is no other suggestions after 7 days, we will choose the first one. -------------------------------------------------------- ???????????????????????????? Pull Request ???????????????????? DolphinScheduler ?????????????????????????? ???????? Specification: [`Open Source Project Name`-`Issue No`][`Module Name`] `Pull Request Description` example?? [DS-3333][server] Fix the xxx exception [DS-3333][server] Implement xxx ... ???????? Specification: [`Pull Request Type`-`Issue No`][`Module Name`] `Pull Request Description` example?? [Fix-3333][server] Fix the xxx exception [Feature-3333][server] Implement xxx ... Pull Request Type ?????? [1] ???????????? ??????????????????Pull request ????????????1??????????????2????????????????????????????7?????????????????????? Pull Request ?????? [1] Pull Request Type: https://github.com/apache/incubator-dolphinscheduler-website/pull/147 Best, Yichao Yang
