2 It’s great.
-------------------- DolphinScheduler(Incubator) Commtter Hemin Wen 温合民 [email protected] -------------------- Yichao Yang <[email protected]> 于2020年7月8日周三 下午9:29写道： > Hi all, > > > After referring to the practices of other open source communities on the > title of pull request, we propose two pre selection schemes for dolphin > scheduler. > > > First： > > Specification: > > [`Open Source Project Name`-`Issue No`][`Module Name`] `Pull Request > Description` > > example： > > [DS-3333][server] Fix the xxx exception > > [DS-3333][server] Implement xxx > > ... > > > > > Second： > > Specification: > > [`Pull Request Type`-`Issue No`][`Module Name`] `Pull Request Description` > > example： > > [Fix-3333][server] Fix the xxx exception > > [Feature-3333][server] Implement xxx > > ... > > The Pull Request type is shown in the screenshot in [1]. > > > > > If you agree with the first one as the title of the pull request, reply 1, > and the second one reply 2. If there is no other suggestions after 7 days, > we will choose the first one. > > > > > -------------------------------------------------------- > > > > > 目前参考了其他开源社区的对于 Pull Request 标题的实践之后，针对 DolphinScheduler 我们提出了两种预选的方案： > > > 第一种： > > Specification: > > [`Open Source Project Name`-`Issue No`][`Module Name`] `Pull Request > Description` > > example： > > [DS-3333][server] Fix the xxx exception > > [DS-3333][server] Implement xxx > > ... > > > > > 第二种： > > Specification: > > [`Pull Request Type`-`Issue No`][`Module Name`] `Pull Request Description` > > example： > > [Fix-3333][server] Fix the xxx exception > > [Feature-3333][server] Implement xxx > > ... > > Pull Request Type 类型在 [1] 中截图给出。 > > > > > 如果想选第一种作为Pull request 标题，则回复1，第二种则回复2。没有其他意见或者建议的话，7天之后默认以第一种作为 Pull > Request 规范。 > > > > > [1] Pull Request Type: > https://github.com/apache/incubator-dolphinscheduler-website/pull/147 > > > > > Best, > > Yichao Yang
