2
------------------ ???????? ------------------ ??????: "JUN GAO"<[email protected]>; ????????: 2020??7??9??(??????) ????11:42 ??????: "dev"<[email protected]>; ????: Re: [Vote] Pull Request Title Specification 2 It is necessary to split large pr into small pr. I agree with the second option. Jave-Chen <[email protected]> ??2020??7??9?????? ????7:30?????? > On one hand, since everyone is free to create issues,&nbsp;different users > may create&nbsp; > issues for the same reason. > > > > On the other hand,&nbsp;spliting a large PR into&nbsp;multiple small PRs > requires developers&nbsp; > to read all prs, would it be inappropriate ?? > > > > > ------------------&nbsp;????????&nbsp;------------------ > ??????:&nbsp;"CalvinKirs"<[email protected]&gt;; > ????????:&nbsp;2020??7??9??(??????) ????2:02 > ??????:&nbsp;"[email protected]"< > [email protected]&gt;; > > ????:&nbsp;Re:[Vote] Pull Request Title Specification > > > > Hi, I think this is a question worthy of recognition.&nbsp; I think our > big pr should be separated, corresponding to an isuess, if it cannot be > split, can it be aggregated into an isuess??how do you think??If I am wrong, > please correct me > > > Best regards?? > CalvinKirs > > > On 07/8/2020 22:22??Jave-Chen<[email protected]&gt; wrote?? > A PR may be associated with multiple issues, so writing Issue No. in PR > titile may&amp;nbsp; > be miscellaneous. > > > > ------------------&amp;nbsp;????????&amp;nbsp;------------------ > ??????:&amp;nbsp;"Yichao Yang"<[email protected]&amp;gt;; > ????????:&amp;nbsp;2020??7??8??(??????) ????9:29 > ??????:&amp;nbsp;"dev"<[email protected]&amp;gt;; > > ????:&amp;nbsp;[Vote] Pull Request Title Specification > > > > Hi all, > > > After referring to the practices of other open source communities on the > title of pull request, we propose two pre selection schemes for dolphin > scheduler. > > > First?? > > Specification: > > [`Open Source Project Name`-`Issue No`][`Module Name`] `Pull Request > Description` > > example?? > > [DS-3333][server] Fix the xxx exception > > [DS-3333][server] Implement xxx > > ... > > > > > Second?? > > Specification: > > [`Pull Request Type`-`Issue No`][`Module Name`] `Pull Request Description` > > example?? > > [Fix-3333][server] Fix the xxx exception > > [Feature-3333][server] Implement xxx > > ... > > The Pull Request type is shown in the screenshot in [1]. > > > > > If you agree with the first one as the title of the pull request, reply 1, > and the second one reply 2. If there is no other suggestions after 7 days, > we will choose the first one. > > > > > -------------------------------------------------------- > > > > > ???????????????????????????? Pull Request ???????????????????? DolphinScheduler ?????????????????????????? > > > ???????? > > Specification: > > [`Open Source Project Name`-`Issue No`][`Module Name`] `Pull Request > Description` > > example?? > > [DS-3333][server] Fix the xxx exception > > [DS-3333][server] Implement xxx > > ... > > > > > ???????? > > Specification: > > [`Pull Request Type`-`Issue No`][`Module Name`] `Pull Request Description` > > example?? > > [Fix-3333][server] Fix the xxx exception > > [Feature-3333][server] Implement xxx > > ... > > Pull Request Type ?????? [1] ???????????? > > > > > ??????????????????Pull request ????????????1??????????????2????????????????????????????7?????????????????????? Pull > Request ?????? > > > > > [1] Pull Request Type: > https://github.com/apache/incubator-dolphinscheduler-website/pull/147 > > > > > Best, > > Yichao Yang -- DolphinScheduler(Incubator) PPMC Jun Gao ???? [email protected]
