imay commented on a change in pull request #368: Add a frontend interface for
committing RoutineLoadTask
URL: https://github.com/apache/incubator-doris/pull/368#discussion_r238942470
##########
File path: fe/src/main/java/org/apache/doris/analysis/InsertStmt.java
##########
@@ -236,11 +236,11 @@ public void analyze(Analyzer analyzer) throws
UserException {
// if all previous job finished
UUID uuid = UUID.randomUUID();
String jobLabel = "insert_" + uuid;
- LoadJobSourceType sourceType = isStreaming ?
LoadJobSourceType.INSERT_STREAMING
+ LoadJobSourceType sourceType = isStreaming ?
LoadJobSourceType.INSERT_STREAMING
: LoadJobSourceType.FRONTEND;
transactionId =
Catalog.getCurrentGlobalTransactionMgr().beginTransaction(db.getId(),
jobLabel,
- "fe", sourceType);
+ "fe", sourceType, null);
Review comment:
Like this, you can add a `beginTransaction` with four parameters, and old
version function call new version add a `null` argument.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
